Added command line argument for examples to pick version of Ogre #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahcorde
approved these changes
Mar 23, 2021
ahcorde
requested changes
Mar 23, 2021
There was a problem hiding this comment.
Do you mind to sign the commit ? https://github.com/ignitionrobotics/ign-rendering/pull/277/checks?check_run_id=2178517512
|
Sorry about, I believe I just signed the commit. I have also configured my GPG key so I think my future commits should contain my signature now. |
ahcorde
approved these changes
Mar 23, 2021
|
looks good to me. Just waiting for CI to finish |
Signed-off-by: WilliamLewww <WilliamMilesLew@gmail.com>
iche033
approved these changes
Mar 31, 2021
iche033
pushed a commit
that referenced
this pull request
May 15, 2021
* Added example for custom shaders with different uniform types Signed-off-by: William Lew <WilliamMilesLew@gmail.com> * Added buffer shader parameter Signed-off-by: William Lew <WilliamMilesLew@gmail.com> * Added ogre uniform buffer update Signed-off-by: William Lew <WilliamMilesLew@gmail.com> * Fixed uninitialized variables Signed-off-by: William Lew <WilliamMilesLew@gmail.com> * Added matrix uniform update Signed-off-by: William Lew <WilliamMilesLew@gmail.com> * Fixed shader paths Signed-off-by: William Lew <WilliamMilesLew@gmail.com> * Added command line argument to pick version of Ogre (#277) Signed-off-by: WilliamLewww <WilliamMilesLew@gmail.com> Signed-off-by: William Lew <WilliamMilesLew@gmail.com> * Fixed C-style cast and formatting issues Signed-off-by: William Lew <WilliamMilesLew@gmail.com> * Changed raw pointer buffer to shared pointer buffer Signed-off-by: William Lew <WilliamMilesLew@gmail.com> * Specified uniform buffer to be a word buffer Signed-off-by: William Lew <WilliamMilesLew@gmail.com> * Fixed codecheck errors Signed-off-by: William Lew <WilliamMilesLew@gmail.com> * Added documentation for word buffer Signed-off-by: William Lew <WilliamMilesLew@gmail.com> * Added tests for word buffer shader parameter Signed-off-by: William Lew <WilliamMilesLew@gmail.com> * Fixed updating int uniform buffer Signed-off-by: William Lew <WilliamMilesLew@gmail.com> * Added tests for int and float uniform buffers Signed-off-by: William Lew <WilliamMilesLew@gmail.com> * Updated example to show different types of uniforms Signed-off-by: William Lew <WilliamMilesLew@gmail.com> * Apply suggestions from code review Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Signed-off-by: William Lew <WilliamMilesLew@gmail.com> * Apply style suggestions Signed-off-by: William Lew <WilliamMilesLew@gmail.com> * Removed support for engines other than OGRE1 Signed-off-by: William Lew <WilliamMilesLew@gmail.com> * Changed "WordBuffer" to "Buffer" Signed-off-by: William Lew <WilliamMilesLew@gmail.com> * Removed raw pointer when getting buffer Signed-off-by: William Lew <WilliamMilesLew@gmail.com> * Added windows support Signed-off-by: William Lew <WilliamMilesLew@gmail.com> * Fixed code check formatting issues Signed-off-by: William Lew <WilliamMilesLew@gmail.com> Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the following examples to use a command line argument to determine which version of Ogre to use (Ogre1 vs. Ogre2):