Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent texture spam #301

Merged
merged 1 commit into from
Apr 7, 2021
Merged

Prevent texture spam #301

merged 1 commit into from
Apr 7, 2021

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Apr 6, 2021

🎉 New feature

Summary

Certain meshes can produce significant amount of output, such as:

[GUI] [Wrn] [SubMesh.cc:478] Multiple texture coordinate sets exist in submesh: WoodBeamRound. Checking first set with index: 0
[GUI] [Wrn] [SubMesh.cc:302] Multiple texture coordinate sets exist in submesh: CeilingRocky. Checking first set with index: 0

Test it

If you have subt installed, run:

ign launch -v 4 cloudsim_sim.ign circuit:=tunnel worldName:=niosh_sr_config_a levels:=false

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

Signed-off-by: Nate Koenig <nate@openrobotics.org>
@nkoenig nkoenig requested a review from iche033 April 6, 2021 20:51
@nkoenig nkoenig changed the base branch from ign-rendering5 to ign-rendering4 April 6, 2021 20:52
@osrf-triage osrf-triage added this to Inbox in Core development Apr 6, 2021
@github-actions github-actions bot added 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress labels Apr 6, 2021
@codecov
Copy link

codecov bot commented Apr 6, 2021

Codecov Report

Merging #301 (f6bccc2) into ign-rendering4 (ccdf27e) will not change coverage.
The diff coverage is 40.00%.

❗ Current head f6bccc2 differs from pull request most recent head f5bd820. Consider uploading reports for the commit f5bd820 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##           ign-rendering4     #301   +/-   ##
===============================================
  Coverage           53.48%   53.48%           
===============================================
  Files                 145      145           
  Lines               13760    13760           
===============================================
  Hits                 7359     7359           
  Misses               6401     6401           
Impacted Files Coverage Δ
ogre/src/OgreMeshFactory.cc 0.00% <0.00%> (ø)
ogre2/src/Ogre2MeshFactory.cc 83.33% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccdf27e...f5bd820. Read the comment docs.

@chapulina chapulina moved this from Inbox to In review in Core development Apr 6, 2021
@chapulina chapulina added 🔮 dome Ignition Dome and removed 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress labels Apr 6, 2021
@nkoenig nkoenig merged commit a2c172a into ign-rendering4 Apr 7, 2021
Core development automation moved this from In review to Done Apr 7, 2021
@nkoenig nkoenig deleted the prevent_texture_spam branch April 7, 2021 15:58
@j-rivero j-rivero removed this from Done in Core development May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔮 dome Ignition Dome
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants