Fix capsule selection #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
|
Ohhhh thanks for tracking that down! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ian Chen ichen@osrfoundation.org
馃 Bug fix
Fixes #283
Summary
The mesh that is created by these lines is more like templates so we should not be giving it a unique name. We then create an instance of the mesh (Ogre::item) and assign it a unique name. However that's not the actual cause of the problem though. It seems like there is an issue that after the mesh with the original name (prefixed by Name(), e.g.
scene::Capsule(65523)) is converted to an item, ogre is not able to find it on mouse click.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge