Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing camera projection type test #361

Merged
merged 1 commit into from
Jul 14, 2021
Merged

Fixing camera projection type test #361

merged 1 commit into from
Jul 14, 2021

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Jul 14, 2021

Signed-off-by: Ian Chen ichen@osrfoundation.org

🦟 Bug fix

Summary

The test has been failing on github CI. It's likely due to uninitialized variable.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

Signed-off-by: Ian Chen <ichen@osrfoundation.org>
@iche033 iche033 marked this pull request as draft July 14, 2021 19:09
@osrf-triage osrf-triage added this to Inbox in Core development Jul 14, 2021
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Jul 14, 2021
@codecov
Copy link

codecov bot commented Jul 14, 2021

Codecov Report

Merging #361 (f6d3724) into main (f28a55f) will increase coverage by 0.10%.
The diff coverage is 57.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #361      +/-   ##
==========================================
+ Coverage   57.92%   58.03%   +0.10%     
==========================================
  Files         166      170       +4     
  Lines       16433    16675     +242     
==========================================
+ Hits         9519     9677     +158     
- Misses       6914     6998      +84     
Impacted Files Coverage Δ
include/ignition/rendering/Scene.hh 0.00% <ø> (ø)
include/ignition/rendering/base/BaseCamera.hh 66.79% <ø> (ø)
include/ignition/rendering/base/BaseScene.hh 0.00% <ø> (ø)
ogre/src/OgreCOMVisual.cc 0.00% <0.00%> (ø)
ogre/src/OgreScene.cc 27.02% <0.00%> (-0.38%) ⬇️
include/ignition/rendering/base/BaseCOMVisual.hh 85.29% <85.29%> (ø)
src/base/BaseScene.cc 75.73% <86.36%> (+0.37%) ⬆️
ogre2/src/Ogre2COMVisual.cc 94.56% <94.56%> (ø)
include/ignition/rendering/COMVisual.hh 100.00% <100.00%> (ø)
ogre2/src/Ogre2Scene.cc 80.73% <100.00%> (+0.15%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac1ab2c...f6d3724. Read the comment docs.

@iche033 iche033 marked this pull request as ready for review July 14, 2021 19:53
Core development automation moved this from Inbox to In review Jul 14, 2021
@chapulina chapulina merged commit 8081b8f into main Jul 14, 2021
Core development automation moved this from In review to Done Jul 14, 2021
@chapulina chapulina deleted the cam_projection_test branch July 14, 2021 20:31
@j-rivero j-rivero removed this from Done in Core development May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants