Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily set number of camera pass count per flush to 0 in ogre2 to prevent downstream build failures #367

Merged
merged 1 commit into from
Jul 20, 2021

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Jul 19, 2021

馃 Bug fix

Temporarily switching Ogre2Scene::cameraPassCountPerGpuFlush back to 0 (old behavior) in ogre2 until all related PRs are merged:

Also applied style fixes as mentioned in #353

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

Signed-off-by: Ian Chen <ichen@osrfoundation.org>
@github-actions github-actions bot added the 馃彚 edifice Ignition Edifice label Jul 19, 2021
@iche033 iche033 changed the base branch from ign-rendering5 to main July 19, 2021 22:56
@osrf-triage osrf-triage added this to Inbox in Core development Jul 19, 2021
@iche033 iche033 added 馃彲 fortress Ignition Fortress and removed 馃彚 edifice Ignition Edifice labels Jul 19, 2021
@codecov
Copy link

codecov bot commented Jul 19, 2021

Codecov Report

Merging #367 (7ef48f3) into main (b7d7d63) will decrease coverage by 0.05%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #367      +/-   ##
==========================================
- Coverage   58.19%   58.14%   -0.06%     
==========================================
  Files         170      170              
  Lines       16787    16788       +1     
==========================================
- Hits         9770     9762       -8     
- Misses       7017     7026       +9     
Impacted Files Coverage 螖
include/ignition/rendering/Scene.hh 0.00% <酶> (酶)
ogre2/src/Ogre2Scene.cc 79.82% <75.00%> (-1.58%) 猬囷笍
include/ignition/rendering/base/BaseCamera.hh 66.66% <0.00%> (-0.38%) 猬囷笍
...e/ignition/rendering/base/BaseGaussianNoisePass.hh 100.00% <0.00%> (+3.33%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update b7d7d63...7ef48f3. Read the comment docs.

@iche033 iche033 changed the title Set number of camera pass count per flush to 0 in ogre2 Temporarily set number of camera pass count per flush to 0 in ogre2 to prevent downstream build failures Jul 19, 2021
Copy link
Contributor

@jennuine jennuine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Core development automation moved this from Inbox to In review Jul 20, 2021
@iche033 iche033 merged commit 742bd27 into main Jul 20, 2021
@iche033 iche033 deleted the legacy_flush branch July 20, 2021 00:45
Core development automation moved this from In review to Done Jul 20, 2021
WilliamLewww pushed a commit to WilliamLewww/ign-rendering that referenced this pull request Dec 7, 2021
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Signed-off-by: William Lew <WilliamMilesLew@gmail.com>
@j-rivero j-rivero removed this from Done in Core development May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
馃彲 fortress Ignition Fortress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants