Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable flaky tests on mac #405

Merged
merged 1 commit into from
Sep 14, 2021
Merged

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Sep 13, 2021

Signed-off-by: Ian Chen ichen@osrfoundation.org

🦟 Bug fix

Related to #369 and #253

Summary

These tests have been failing from time to time on macOs.

There was a pull request to address #369 but I think the test still fails on certain graphics card, e.g. Intel HD Graphics 4000 as described in #369

Disabling the tests until we have time to fix them.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

Signed-off-by: Ian Chen <ichen@osrfoundation.org>
@github-actions github-actions bot added the 🏢 edifice Ignition Edifice label Sep 13, 2021
@osrf-triage osrf-triage added this to Inbox in Core development Sep 13, 2021
@codecov
Copy link

codecov bot commented Sep 13, 2021

Codecov Report

Merging #405 (5be2215) into ign-rendering5 (74f88b7) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 5be2215 differs from pull request most recent head a105371. Consider uploading reports for the commit a105371 to get more accurate results
Impacted file tree graph

@@                Coverage Diff                 @@
##           ign-rendering5     #405      +/-   ##
==================================================
- Coverage           57.77%   57.77%   -0.01%     
==================================================
  Files                 161      161              
  Lines               15947    15947              
==================================================
- Hits                 9214     9213       -1     
- Misses               6733     6734       +1     
Impacted Files Coverage Δ
...e/ignition/rendering/base/BaseGaussianNoisePass.hh 96.66% <0.00%> (-3.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74f88b7...a105371. Read the comment docs.

@chapulina chapulina added macOS macOS support tests Broken or missing tests / testing infra labels Sep 14, 2021
Core development automation moved this from Inbox to In review Sep 14, 2021
@chapulina chapulina merged commit 49e7a06 into ign-rendering5 Sep 14, 2021
Core development automation moved this from In review to Done Sep 14, 2021
@chapulina chapulina deleted the disable_tests_on_mac branch September 14, 2021 16:58
@j-rivero j-rivero removed this from Done in Core development May 6, 2022
Crola1702 pushed a commit to Crola1702/gz-rendering-backport that referenced this pull request Jul 29, 2022
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Blast545 pushed a commit that referenced this pull request Aug 1, 2022
Signed-off-by: Ian Chen <ichen@osrfoundation.org>

Co-authored-by: Ian Chen <ichen@osrfoundation.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏢 edifice Ignition Edifice macOS macOS support tests Broken or missing tests / testing infra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants