Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix heightmap crash if only shadow casting spotlights are one scene #451

Merged
merged 3 commits into from
Oct 7, 2021
Merged

Fix heightmap crash if only shadow casting spotlights are one scene #451

merged 3 commits into from
Oct 7, 2021

Conversation

darksylinc
Copy link
Contributor

🦟 Bug fix

Fixes #439

Summary

Not much to say. This is a fix from upstream.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

@darksylinc
Fix heightmap crash if only shadow casting spotlights are one scene
68cd616 
Fixes gazebosim#439

Signed-off-by: Matias N. Goldberg <dark_sylinc@yahoo.com.ar>
@osrf-triage osrf-triage added this to Inbox in Core development Oct 3, 2021
@codecov
Copy link

codecov bot commented Oct 3, 2021 •
edited

Codecov Report

Merging #451 (0ade119) into ign-rendering6 (e17fafd) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           ign-rendering6     #451   +/-   ##
===============================================
  Coverage           53.49%   53.49%           
===============================================
  Files                 192      192           
  Lines               19560    19560           
===============================================
  Hits                10464    10464           
  Misses               9096     9096

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e17fafd...0ade119. Read the comment docs.

@chapulina chapulina moved this from Inbox to In review in Core development Oct 4, 2021
@iche033 iche033 changed the base branch from main to ign-rendering6 October 4, 2021 22:09
iche033
iche033 approved these changes Oct 4, 2021
View reviewed changes
Copy link
Contributor

@iche033 iche033 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixes the crash for me, thanks for the fix!

@iche033 iche033 enabled auto-merge (squash) October 4, 2021 22:09
@iche033 iche033 disabled auto-merge October 7, 2021 06:02
@iche033 iche033 merged commit c9e76e9 into gazebosim:ign-rendering6 Oct 7, 2021
Core development automation moved this from In review to Done Oct 7, 2021
@iche033 iche033 mentioned this pull request Oct 7, 2021
Closed
3 tasks
srmainwaring pushed a commit to srmainwaring/gz-rendering that referenced this pull request Oct 21, 2021
@darksylinc @iche033 @srmainwaring
Fix heightmap crash if only shadow casting spotlights are one scene (g…
7c90f64 
…azebosim#451)

Fixes gazebosim#439

Signed-off-by: Matias N. Goldberg <dark_sylinc@yahoo.com.ar>

Co-authored-by: Ian Chen <ichen@osrfoundation.org>
@j-rivero j-rivero removed this from Done in Core development May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iche033 iche033 iche033 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@darksylinc @iche033