Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃 Bug fix
Fixes #464
Summary
The Urban Station model appears red when loaded in ign-gazebo. This was due to using a grayscale texture map. The single channel texture is loaded into the red component of the diffuse texture. A check for grayscale textures was added to fix this issue before but it was added inside another check that never gets reached if the material is set through the dae file (and not set through the SDF element).
This PR makes minor tweak so that all textures set to the mesh are checked to see if it's grayscale.
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge