Support using custom shader materials and updating uniform variables (ogre2) #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## ign-rendering6 #520 +/- ##
==================================================
- Coverage 54.70% 54.48% -0.22%
==================================================
Files 198 198
Lines 20029 20125 +96
==================================================
+ Hits 10956 10966 +10
- Misses 9073 9159 +86
Continue to review full report at Codecov.
|
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
iche033
changed the title
| @@ -64,6 +68,19 @@ void buildScene(ScenePtr _scene) | |||
| light0->SetSpecularColor(0.5, 0.5, 0.5); | |||
| root->AddChild(light0); | |||
|
|
|||
| t std::string vertexShaderFile; | |||
There was a problem hiding this comment.
Suggested change
| t std::string vertexShaderFile; | |
| std::string vertexShaderFile; |
There was a problem hiding this comment.
oops, fixed. 00d56a1
WilliamLewww
approved these changes
Dec 24, 2021
7 tasks
8 tasks
|
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-ignition-releases-2022-03-01-citadel-edifice-fortress/1313/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ian Chen ichen@osrfoundation.org
Implemented code to supported loading custom shader material and updating their uniform variables.
Extended the
custom_shaders_uniformsto run with ogre2 render engine. Note I made a slight tweak to the shader code in the demo to make the ogre 1.x and ogre 2.x behavior more consistent. When running withogre2, the clip space z pos returned bygl_Position.zis different fromogreso it was rendering slightly different visual effect.To test:
build and run the custom_shaders_uniforms demo: