Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase particle emitter quota #562

Merged
merged 1 commit into from
Feb 17, 2022
Merged

Increase particle emitter quota #562

merged 1 commit into from
Feb 17, 2022

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Feb 17, 2022

Signed-off-by: Ian Chen ichen@osrfoundation.org

馃 Bug fix

Summary

Increase particle quota - this is the max number of particles present in the scene. The changes here increase the limit so that we can generate denser particle effects in larger environments.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Ian Chen <ichen@osrfoundation.org>
@iche033 iche033 requested a review from caguero February 17, 2022 00:24
@github-actions github-actions bot added the 馃彲 fortress Ignition Fortress label Feb 17, 2022
@osrf-triage osrf-triage added this to Inbox in Core development Feb 17, 2022
@iche033 iche033 mentioned this pull request Feb 17, 2022
@mjcarroll
Copy link
Contributor

Does this have any impact on performance? Or does it just allow more particles to be added in total?

@codecov
Copy link

codecov bot commented Feb 17, 2022

Codecov Report

Merging #562 (5a90703) into ign-rendering6 (112d5d4) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           ign-rendering6     #562   +/-   ##
===============================================
  Coverage           54.37%   54.37%           
===============================================
  Files                 198      198           
  Lines               20151    20151           
===============================================
  Hits                10957    10957           
  Misses               9194     9194           
Impacted Files Coverage 螖
ogre2/src/Ogre2ParticleEmitter.cc 78.00% <100.00%> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 112d5d4...5a90703. Read the comment docs.

@iche033
Copy link
Contributor Author

iche033 commented Feb 17, 2022

This just allows more particles to be added in total. It will only have a performance impact if the user specifies to have a high rate of particles emitted in short period of time (now that there can be more particles at any one time).

Core development automation moved this from Inbox to In review Feb 17, 2022
@mjcarroll mjcarroll merged commit e0ed1b1 into ign-rendering6 Feb 17, 2022
@mjcarroll mjcarroll deleted the particle_quota branch February 17, 2022 13:08
Core development automation moved this from In review to Done Feb 17, 2022
@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-03-01-citadel-edifice-fortress/1313/1

@j-rivero j-rivero removed this from Done in Core development May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
馃彲 fortress Ignition Fortress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants