Fix shaders for other sensors that require material switching (ogre2) #579
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ian Chen ichen@osrfoundation.org
🦟 Bug fix
Summary
Follow-up to ##575 and these comments
This PR fixes objects with shader material when there is a thermal camera or a segmentation camera in the scene. These sensor all perform material switching during a render update, and the shader materials should now be correctly restored. Also updated test.
Here is a shader_param_sensors.sdf for testing with ign-gazebo. The cameras should produce correct output and the waves and deformable sphere should be render correctly in the GUI and camera and depth sensors.
Note that the thermal and segmentation cameras do not show the animation of waves and is being addressed in #578 (which has a separate fix for this issue targeting ign-rendering7).
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.