Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement consistent Auto Aspect Ratio #764

Merged
merged 7 commits into from
Nov 30, 2022
Merged

Implement consistent Auto Aspect Ratio #764

merged 7 commits into from
Nov 30, 2022

Commits on Nov 26, 2022

  1. Implement consistent Auto Aspect Ratio 

    The old default Aspect Ratio would be 1.3333
Now it is 0.0 which indicates Gazebo should autocalculate the Aspect
Ratio.

This results in a nice backwards-compatible behavior while fixing
various bugs mentioned in gazebosim#763

Fixes gazebosim#763

Signed-off-by: Matias N. Goldberg <dark_sylinc@yahoo.com.ar>
    @darksylinc
    darksylinc committed Nov 26, 2022
    Configuration menu
    Copy the full SHA
    bfb4985 View commit details
    Browse the repository at this point in the history

  2. Fix codecheck 

    Add AspectRatio unit test
Highly reduce the error tolerance on Camera UNIT test

Signed-off-by: Matias N. Goldberg <dark_sylinc@yahoo.com.ar>
    @darksylinc
    darksylinc committed Nov 26, 2022
    Configuration menu
    Copy the full SHA
    5f449ea View commit details
    Browse the repository at this point in the history

  3. Test explicit Aspect Ratio 

    Signed-off-by: Matias N. Goldberg <dark_sylinc@yahoo.com.ar>
    @darksylinc
    darksylinc committed Nov 26, 2022
    Configuration menu
    Copy the full SHA
    003ee57 View commit details
    Browse the repository at this point in the history

  4. Add AspectRatio integration test 

    Signed-off-by: Matias N. Goldberg <dark_sylinc@yahoo.com.ar>
    @darksylinc
    darksylinc committed Nov 26, 2022
    Configuration menu
    Copy the full SHA
    7bdec8b View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2022

  1. Merge branch 'gz-rendering7' into matias-autoAspectRatio

    @iche033
    iche033 committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    4500293 View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2022

  1. Remove debug code that shouldn't have been pushed 

    Signed-off-by: Matias N. Goldberg <dark_sylinc@yahoo.com.ar>
    @darksylinc
    darksylinc committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    0489035 View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2022

  1. Merge branch 'gz-rendering7' into matias-autoAspectRatio

    @iche033
    iche033 committed Nov 30, 2022
    Configuration menu
    Copy the full SHA
    b0bd046 View commit details
    Browse the repository at this point in the history