Implement consistent Auto Aspect Ratio #764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old default Aspect Ratio would be 1.3333 Now it is 0.0 which indicates Gazebo should autocalculate the Aspect Ratio. This results in a nice backwards-compatible behavior while fixing various bugs mentioned in gazebosim#763 Fixes gazebosim#763 Signed-off-by: Matias N. Goldberg <dark_sylinc@yahoo.com.ar>
Add AspectRatio unit test Highly reduce the error tolerance on Camera UNIT test Signed-off-by: Matias N. Goldberg <dark_sylinc@yahoo.com.ar>
Signed-off-by: Matias N. Goldberg <dark_sylinc@yahoo.com.ar>
Signed-off-by: Matias N. Goldberg <dark_sylinc@yahoo.com.ar>
darksylinc
force-pushed
the
matias-autoAspectRatio
branch
from
42af876
to
7bdec8b
Compare
Codecov Report
@@ Coverage Diff @@
## gz-rendering7 #764 +/- ##
=================================================
+ Coverage 75.48% 75.49% +0.01%
=================================================
Files 164 164
Lines 14364 14374 +10
=================================================
+ Hits 10843 10852 +9
- Misses 3521 3522 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
iche033
approved these changes
Nov 29, 2022
Signed-off-by: Matias N. Goldberg <dark_sylinc@yahoo.com.ar>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃 Bug fix
Fixes #763
Summary
The old default Aspect Ratio would be 1.3333
Now it is 0.0 which indicates Gazebo should autocalculate the Aspect Ratio.
This results in a nice backwards-compatible behavior while fixing various bugs mentioned in #763
Fixes #763
Signed-off-by: Matias N. Goldberg dark_sylinc@yahoo.com.ar
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.