Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update test configuration to use ogre2 #83

Merged
merged 12 commits into from
Jun 29, 2020
Merged

Update test configuration to use ogre2 #83

merged 12 commits into from
Jun 29, 2020

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented May 8, 2020 •
edited

see gazebosim/gz-sim#14

May need to fix CI...

@iche033
use ogre2 test
17af7b8 
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
@iche033 iche033 requested a review from chapulina May 8, 2020 23:07
@iche033 iche033 self-assigned this May 8, 2020
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label May 8, 2020
@osrf-triage osrf-triage added this to Inbox in Core development May 8, 2020
@codecov
Copy link

codecov bot commented May 8, 2020 •
edited

Codecov Report

Merging #83 into ign-rendering3 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##           ign-rendering3     #83   +/-   ##
==============================================
  Coverage            7.81%   7.81%           
==============================================
  Files                  25      25           
  Lines                1689    1689           
==============================================
  Hits                  132     132           
  Misses               1557    1557

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d247a4...9638b8e. Read the comment docs.

@chapulina
Copy link
Contributor

Interesting that no ogre2 files are showing on the coverage report: https://codecov.io/gh/ignitionrobotics/ign-rendering/tree/17af7b8296830b2f45e165a432611ed2ef855ccc/src

@chapulina chapulina moved this from Inbox to In progress in Core development May 11, 2020
@iche033 iche033 marked this pull request as draft May 11, 2020 19:53
@iche033
changelog
52299a4 
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
@iche033 iche033 marked this pull request as ready for review May 21, 2020 01:05
@iche033
run test
4bbd43d 
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
@iche033
testing
ed7d3f5 
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
@iche033 iche033 marked this pull request as draft May 21, 2020 19:08
@iche033
revert changes
377c659 
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
@iche033 iche033 marked this pull request as ready for review May 22, 2020 21:22
@iche033
Copy link
Contributor Author

iche033 commented May 22, 2020

ok CI should be working. More tests are passing on windows compared to ogre 1.x even though there are still issues with loading the render engine plugin.

@chapulina
Copy link
Contributor

Should we try to address the new test failure on homebrew?

https://build.osrfoundation.org/job/ignition_rendering-ci-pr_any-homebrew-amd64/666/testReport/junit/(root)/DepthCamera_DepthCameraTest/DepthCameraBoxes_ogre2/

ign-rendering3 has a clean track record: https://build.osrfoundation.org/job/ignition_rendering-ci-ign-rendering3-homebrew-amd64/

@chapulina chapulina mentioned this pull request May 25, 2020
Open
@iche033
testing
9ec83bb 
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
@iche033 iche033 marked this pull request as draft June 13, 2020 00:49
@iche033
add ifdefs
27a1e30 
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
@iche033
debugging homebrew
bbbf691 
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
@iche033
more debugging
0c1b1c0 
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
@iche033
debugging depth cam mat and comp
39b1d3a 
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
@iche033
fix build
d77e3e4 
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
@iche033
cleanup
9638b8e 
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
@iche033 iche033 marked this pull request as ready for review June 29, 2020 18:24
@iche033
Copy link
Contributor Author

iche033 commented Jun 29, 2020 •
edited

disabled DepthCamera test on macOS and ticketed issue #108

This PR is ready for review again

chapulina
chapulina approved these changes Jun 29, 2020
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Core development automation moved this from In progress to In review Jun 29, 2020
@iche033 iche033 merged commit f54768c into ign-rendering3 Jun 29, 2020
Core development automation moved this from In review to Done Jun 29, 2020
@iche033 iche033 deleted the use_ogre2_test branch June 29, 2020 22:35
@chapulina chapulina mentioned this pull request Aug 4, 2020
Merged
@j-rivero j-rivero removed this from Done in Core development May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

Assignees

@iche033 iche033

Labels
🏰 citadel Ignition Citadel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@iche033 @chapulina