Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix visibility decorator of Ogre2Projector #850

Merged
merged 1 commit into from
May 20, 2023

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented May 20, 2023

🦟 Bug fix

Fix visibility decorator of Ogre2Projector class.

Summary

Ogre2Projector was decorated by GZ_RENDERING_OGRE_VISIBLE instead of GZ_RENDERING_OGRE2_VISIBLE, probably a copy&paste error.

I noticed this as by building gz-rendering with SKIP_ogre, the build was failing with:

In file included from /home/traversaro/gz-ws/src/gz-rendering/ogre2/src/Ogre2Projector.cc:30:
/home/traversaro/gz-ws/src/gz-rendering/ogre2/include/gz/rendering/ogre2/Ogre2Projector.hh:26:10: fatal error: gz/rendering/ogre/Export.hh: No such file or directory
   26 | #include "gz/rendering/ogre/Export.hh"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Silvio Traversaro <silvio.traversaro@iit.it>
@traversaro traversaro requested a review from iche033 as a code owner May 20, 2023 13:52
@osrf-triage osrf-triage added this to Inbox in Core development May 20, 2023
@github-actions github-actions bot added the 🌱 garden Ignition Garden label May 20, 2023
@codecov
Copy link

codecov bot commented May 20, 2023

Codecov Report

Merging #850 (6395a15) into gz-rendering7 (86395fa) will not change coverage.
The diff coverage is n/a.

❗ Current head 6395a15 differs from pull request most recent head cac14ee. Consider uploading reports for the commit cac14ee to get more accurate results

@@              Coverage Diff               @@
##           gz-rendering7     #850   +/-   ##
==============================================
  Coverage          77.14%   77.14%           
==============================================
  Files                170      170           
  Lines              14716    14716           
==============================================
  Hits               11353    11353           
  Misses              3363     3363           

Core development automation moved this from Inbox to In review May 20, 2023
@azeey azeey merged commit ef4abec into gazebosim:gz-rendering7 May 20, 2023
8 of 9 checks passed
Core development automation moved this from In review to Done May 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants