Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add private data class to Image #875

Merged
merged 6 commits into from
Jul 26, 2023
Merged

Add private data class to Image #875

merged 6 commits into from
Jul 26, 2023

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Jul 25, 2023

🎉 New feature

Summary

Pimpl'ize Image class

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Jul 25, 2023
@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Merging #875 (4860af8) into main (9a76f1f) will decrease coverage by 0.01%.
Report is 2 commits behind head on main.
The diff coverage is 71.42%.

❗ Current head 4860af8 differs from pull request most recent head abea76a. Consider uploading reports for the commit abea76a to get more accurate results

@@            Coverage Diff             @@
##             main     #875      +/-   ##
==========================================
- Coverage   75.10%   75.09%   -0.01%     
==========================================
  Files         176      176              
  Lines       16853    16859       +6     
==========================================
+ Hits        12658    12661       +3     
- Misses       4195     4198       +3     
Files Changed Coverage Δ
include/gz/rendering/Image.hh 50.00% <50.00%> (ø)
src/Image.cc 78.12% <72.22%> (-6.50%) ⬇️
src/RenderEngineManager.cc 76.89% <100.00%> (ø)

include/gz/rendering/Image.hh Outdated Show resolved Hide resolved
src/Image.cc Show resolved Hide resolved
@iche033 iche033 requested a review from ahcorde July 26, 2023 17:18
src/Image.cc Show resolved Hide resolved
Signed-off-by: Ian Chen <ichen@openrobotics.org>
@ahcorde ahcorde requested a review from mjcarroll July 26, 2023 20:39
@iche033 iche033 merged commit a1d4e87 into main Jul 26, 2023
6 of 10 checks passed
@iche033 iche033 deleted the image_pimpl branch July 26, 2023 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants