Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove inheritance from common::Singleton for all classes #876

Merged
merged 2 commits into from
Jul 27, 2023

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Jul 26, 2023

🦟 Bug fix

Summary

Continuing the effort from #874, this PR removes inheritance from common::Singleton for all other classes.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Ian Chen <ichen@openrobotics.org>
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Jul 26, 2023
@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Merging #876 (50c9300) into main (a1d4e87) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 50c9300 differs from pull request most recent head f34ce02. Consider uploading reports for the commit f34ce02 to get more accurate results

@@           Coverage Diff           @@
##             main     #876   +/-   ##
=======================================
  Coverage   75.09%   75.09%           
=======================================
  Files         176      176           
  Lines       16859    16859           
=======================================
  Hits        12661    12661           
  Misses       4198     4198           
Files Changed Coverage Δ
...e2/include/gz/rendering/ogre2/Ogre2RenderEngine.hh 100.00% <ø> (ø)
ogre2/src/Ogre2RenderEngine.cc 68.18% <100.00%> (ø)

@iche033 iche033 merged commit e58870c into main Jul 27, 2023
7 of 10 checks passed
@iche033 iche033 deleted the rm_singleton_inheritance branch July 27, 2023 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants