Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update installation instructions #906

Merged
merged 2 commits into from
Sep 14, 2023
Merged

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Sep 14, 2023

🦟 Bug fix

gazebosim/gazebo_test_cases#155

Summary

  • Replaced ign with gz
  • Updated windows instructions
  • Updated ogre-next lib name

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Ian Chen <ichen@openrobotics.org>
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Sep 14, 2023
@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Merging #906 (534658a) into gz-rendering8 (890cc29) will not change coverage.
The diff coverage is n/a.

❗ Current head 534658a differs from pull request most recent head 82cab51. Consider uploading reports for the commit 82cab51 to get more accurate results

@@              Coverage Diff               @@
##           gz-rendering8     #906   +/-   ##
==============================================
  Coverage          75.21%   75.21%           
==============================================
  Files                176      176           
  Lines              16839    16839           
==============================================
  Hits               12665    12665           
  Misses              4174     4174           

Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a small nit

tutorials/02_install.md Outdated Show resolved Hide resolved
Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Signed-off-by: Michael Carroll <carroll.michael@gmail.com>
@mjcarroll mjcarroll merged commit 98c5978 into gz-rendering8 Sep 14, 2023
3 of 9 checks passed
@mjcarroll mjcarroll deleted the update_installation branch September 14, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants