Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added airspeed sensor #305

Merged
merged 11 commits into from Feb 9, 2023
Merged

Added airspeed sensor #305

merged 11 commits into from Feb 9, 2023

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Dec 23, 2022

Signed-off-by: Alejandro Hernández Cordero ahcorde@gmail.com

🎉 New feature

Summary

Added air speed sensor

Depends on:

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Dec 23, 2022
@osrf-triage osrf-triage added this to Inbox in Core development Dec 23, 2022
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
@ahcorde ahcorde self-assigned this Feb 3, 2023
@ahcorde ahcorde requested a review from jennuine February 3, 2023 13:42
@ahcorde ahcorde moved this from In progress to In review in Core development Feb 3, 2023
@ahcorde ahcorde marked this pull request as ready for review February 3, 2023 13:42
@ahcorde ahcorde requested a review from iche033 as a code owner February 3, 2023 13:42
@iche033 iche033 added the needs upstream release Blocked by a release of an upstream library label Feb 3, 2023
Copy link
Contributor

@jennuine jennuine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test for this?

include/gz/sensors/AirSpeedSensor.hh Outdated Show resolved Hide resolved
include/gz/sensors/AirSpeedSensor.hh Outdated Show resolved Hide resolved
src/AirSpeedSensor.cc Outdated Show resolved Hide resolved
src/AirSpeedSensor.cc Outdated Show resolved Hide resolved
src/AirSpeedSensor.cc Outdated Show resolved Hide resolved
src/AirSpeedSensor.cc Outdated Show resolved Hide resolved
src/AirSpeedSensor.cc Outdated Show resolved Hide resolved
include/gz/sensors/AirSpeedSensor.hh Outdated Show resolved Hide resolved
src/AirSpeedSensor.cc Show resolved Hide resolved
src/AirSpeedSensor.cc Outdated Show resolved Hide resolved
src/AirSpeedSensor.cc Show resolved Hide resolved
src/AirSpeedSensor.cc Outdated Show resolved Hide resolved
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
@ahcorde ahcorde requested a review from jennuine February 8, 2023 09:19
@codecov
Copy link

codecov bot commented Feb 8, 2023

Codecov Report

Merging #305 (8ca5869) into gz-sensors7 (45c1761) will increase coverage by 0.19%.
The diff coverage is 79.72%.

❗ Current head 8ca5869 differs from pull request most recent head fe3abbc. Consider uploading reports for the commit fe3abbc to get more accurate results

@@               Coverage Diff               @@
##           gz-sensors7     #305      +/-   ##
===============================================
+ Coverage        69.61%   69.80%   +0.19%     
===============================================
  Files               35       36       +1     
  Lines             3814     3888      +74     
===============================================
+ Hits              2655     2714      +59     
- Misses            1159     1174      +15     
Impacted Files Coverage Δ
src/AirSpeedSensor.cc 79.72% <79.72%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

ahcorde and others added 2 commits February 8, 2023 17:01
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
@ahcorde
Copy link
Contributor Author

ahcorde commented Feb 9, 2023

friendly ping @jennuine

@iche033
Copy link
Contributor

iche033 commented Feb 9, 2023

hmm windows build has some linker errors

Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
@ahcorde
Copy link
Contributor Author

ahcorde commented Feb 9, 2023

@iche033 Fixed

@ahcorde ahcorde requested a review from iche033 February 9, 2023 23:06
@ahcorde ahcorde merged commit 7c8ce56 into gz-sensors7 Feb 9, 2023
Core development automation moved this from In review to Done Feb 9, 2023
@ahcorde ahcorde deleted the ahcorde/air_speed branch February 9, 2023 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants