Add Gps Sensor to IGN-Sensors library #72
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 30, 2020 19:19
Signed-off-by: Dre Westcook <dre.west@outlook.com>
Signed-off-by: Dre Westcook <dre.west@outlook.com>
ahcorde
requested changes
Dec 30, 2020
There was a problem hiding this comment.
Please review the style comments and check the CI you have some linters errors.
Do you mind to add some tests too ? (like these ones https://github.com/ignitionrobotics/ign-sensors/tree/ign-sensors4/test/integration)
added 2 commits
December 31, 2020 13:51
Signed-off-by: Dre Westcook <dre.west@outlook.com>
Signed-off-by: Dre Westcook <dre.west@outlook.com>
|
Added some tests and I fixed up the linting errors from the ./tools/code_check.sh script. this is going to need gazebosim/sdformat#453 to be accepted before it willl compile here, just for the fyi. I think most of the help I might need would be on the gazebo sim side. gazebosim/gz-sim#519 I'll fix up the lint on there soon. |
chapulina
added
the
needs upstream release
|
@Dotrar , the SDFormat PR has been merged. Are you interested in iterating on this PR and the one in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues:
#23
gazebosim/sdformat#453
very similar to the imu and altimeter sensor objects, just a gps sensor, hopefully as one would expect.