Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed markdown-header #161

Merged
merged 3 commits into from
Aug 17, 2020
Merged

Removed markdown-header #161

merged 3 commits into from
Aug 17, 2020

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Aug 17, 2020

Signed-off-by: ahcorde ahcorde@gmail.com

@ahcorde
Removed markdown hader
a30906a 
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde added the documentation Improvements or additions to documentation label Aug 17, 2020
@ahcorde ahcorde requested a review from chapulina August 17, 2020 14:37
@ahcorde ahcorde requested a review from caguero as a code owner August 17, 2020 14:37
@ahcorde ahcorde self-assigned this Aug 17, 2020
@github-actions github-actions bot added the 🔮 dome Ignition Dome label Aug 17, 2020
@osrf-triage osrf-triage added this to Inbox in Core development Aug 17, 2020
@codecov
Copy link

codecov bot commented Aug 17, 2020 •
edited
Loading

Codecov Report

Merging #161 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #161   +/-   ##
=======================================
  Coverage   83.97%   83.97%           
=======================================
  Files          49       49           
  Lines        4725     4725           
=======================================
  Hits         3968     3968           
  Misses        757      757

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56b5047...550de18. Read the comment docs.

Core development automation moved this from Inbox to In review Aug 17, 2020
caguero
caguero approved these changes Aug 17, 2020
View reviewed changes
Copy link
Contributor

@caguero caguero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a minor tweak but looks good!

@chapulina chapulina merged commit edbd40a into master Aug 17, 2020
Core development automation moved this from In review to Done Aug 17, 2020
@chapulina chapulina deleted the ahcorde/fix/markdown-header branch August 17, 2020 16:42
@ahcorde ahcorde mentioned this pull request Aug 18, 2020
Closed
@j-rivero j-rivero removed this from Done in Core development May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caguero caguero caguero approved these changes

@chapulina chapulina chapulina approved these changes

Assignees

@ahcorde ahcorde

Labels
documentation Improvements or additions to documentation 🔮 dome Ignition Dome
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ahcorde @caguero @chapulina