Merge ign-transport8 ➡️ ign-transport11 #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mabel Zhang <mabel@openrobotics.org> Signed-off-by: Louise Poubel <louise@openrobotics.org> Co-authored-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
ahcorde
requested changes
Jul 20, 2022
There was a problem hiding this comment.
this is not compiling
/github/workspace/src/cmd/ign_TEST.cc: In member function 'virtual void ignTest_ServiceHelpVsCompletionFlags_Test::TestBody()':
/github/workspace/src/cmd/ign_TEST.cc:472:38: error: 'PROJECT_SOURCE_DIR' was not declared in this scope
std::filesystem::path scriptPath = PROJECT_SOURCE_DIR;
Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
Should be fixed here: c0c54bb @mabelzhang can you double check the updates I did were correct? I saw a couple |
|
Your updates look good to me. (and |
|
The new |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
➡️ Forward port
Port
ign-transport8➡️ign-transport11Branch comparision: ign-transport11...ign-transport8
Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)