Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a wide angle camera with lens flare plugin #7

Merged
merged 4 commits into from
Sep 29, 2023

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Sep 6, 2023

🎉 New feature

Summary

Updated the camera sensor to be a wide angle camera with lens flare plugin. Mounted it on a post at the back of the house so it's not just floating in mid air.

Needs wide angle camera and lens flare fixes in:

harmonic_wide_angle_cam

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Ian Chen <ichen@openrobotics.org>
@iche033 iche033 changed the title wide angle camera lens flares Add a wide angle camera with lens flare plugin Sep 6, 2023
Signed-off-by: Ian Chen <ichen@openrobotics.org>
Signed-off-by: Ian Chen <ichen@openrobotics.org>
@iche033
Copy link
Contributor Author

iche033 commented Sep 29, 2023

merging this as the demo was already presented

@iche033 iche033 merged commit e41f701 into main Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant