Support specifying the name of light associated with lens flares #2172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Chen <ichen@openrobotics.org>
Signed-off-by: Ian Chen <ichen@openrobotics.org>
9 tasks
ahcorde
approved these changes
Sep 26, 2023
mjcarroll
approved these changes
Sep 28, 2023
mabelzhang
pushed a commit
that referenced
this pull request
Nov 1, 2023
--------- Signed-off-by: Ian Chen <ichen@openrobotics.org> Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃帀 New feature
Summary
Currently by default, the lens flares system just picks the first light in the scene which may not always be what the user wants. This PR adds a new plugin param named
<light_name>for users to specify the name of the light for the lens flares.Needed by gazebosim/harmonic_demo#7 in order for lens flares to be visible in the camera view.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.