Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GoogleTest to latest version #658

Merged
merged 7 commits into from
Jun 28, 2022
Merged

Update GoogleTest to latest version #658

merged 7 commits into from
Jun 28, 2022

Conversation

mjcarroll
Copy link
Contributor

Import latest version of GoogleTest from upstream and adjust build accordingly.

Tracking issue: gazebosim/gz-sim#1537

Signed-off-by: Michael Carroll michael@openrobotics.org

@mjcarroll
Remove old gtest version
573ae06 
Signed-off-by: Michael Carroll <michael@openrobotics.org>
@mjcarroll
Add new vendored Googletest version
5823c97 
Signed-off-by: Michael Carroll <michael@openrobotics.org>
@mjcarroll
Move test_config H to HH
ef43dbf 
Signed-off-by: Michael Carroll <michael@openrobotics.org>
@mjcarroll
CMake updates for new googletest version
756b605 
Signed-off-by: Michael Carroll <michael@openrobotics.org>
@mjcarroll
Test updates for new googletest version
d434800 
Signed-off-by: Michael Carroll <michael@openrobotics.org>
@mjcarroll
Remove unnecessary gtest_main functions
dc9dd54 
Signed-off-by: Michael Carroll <michael@openrobotics.org>
@mjcarroll mjcarroll marked this pull request as ready for review June 28, 2022 05:54
@mjcarroll mjcarroll requested a review from iche033 as a code owner June 28, 2022 05:54
@mjcarroll mjcarroll mentioned this pull request Jun 28, 2022
Closed
14 tasks
@osrf-triage osrf-triage added this to Inbox in Core development Jun 28, 2022
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Jun 28, 2022
@codecov
Copy link

codecov bot commented Jun 28, 2022 •
edited

Codecov Report

Merging #658 (4c1745a) into main (a781e09) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #658   +/-   ##
=======================================
  Coverage   53.58%   53.59%           
=======================================
  Files         214      214           
  Lines       21421    21420    -1     
=======================================
  Hits        11479    11479           
+ Misses       9942     9941    -1
Impacted Files Coverage Δ
ogre2/src/terrain/Terra/src/Terra.cpp 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a781e09...4c1745a. Read the comment docs.

@chapulina chapulina added the tests Broken or missing tests / testing infra label Jun 28, 2022
Core development automation moved this from Inbox to In review Jun 28, 2022
@mjcarroll mjcarroll merged commit 67ee5db into main Jun 28, 2022
Core development automation moved this from In review to Done Jun 28, 2022
@mjcarroll mjcarroll deleted the bump_gtest branch June 28, 2022 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

@iche033 iche033 Awaiting requested review from iche033 iche033 is a code owner

Assignees
No one assigned
Labels
🌱 garden Ignition Garden tests Broken or missing tests / testing infra
Projects
Core development
Archived in project
Core development
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mjcarroll @chapulina