Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pkg-config as a buildtool dependency #102

Merged
merged 2 commits into from
Aug 20, 2020
Merged

Conversation

chapulina
Copy link
Contributor

@nuclearsandwich kindly helped me investigate why the ros_ign packages are failing to build for Foxy and this is a promising band-aid solution.

Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina added ROS 2 ROS 2 bug Something isn't working labels Aug 19, 2020
@osrf-triage osrf-triage added this to Inbox in Core development Aug 19, 2020
@chapulina chapulina moved this from Inbox to In review in Core development Aug 19, 2020
@chapulina chapulina self-assigned this Aug 19, 2020
@nuclearsandwich
Copy link

I think you also need this in ros_ign_gazebo based on the failures here: http://build.ros2.org/view/Fbin_uF64/job/Fbin_uF64__ros_ign_gazebo__ubuntu_focal_amd64__binary/

@nuclearsandwich
Copy link

If ign-cmake was a ROS package, the common practice would be to add a buildtool_export_depend on pkg-config so that any package downstream of ign-cmake got the dependency needed to use its bundled cmake modules.

It's not a ROS package so while that possibility is entertained this PR moves forward with a local solution to include pkg-config as a buildtool dependency in the packages which use ign-cmake bundled modules that expect pkg-config to be available.

Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina
Copy link
Contributor Author

chapulina commented Aug 19, 2020

I think you also need this in ros_ign_gazebo

You're right, I forgot that also links against ign-transport. 02be7a7

Copy link

@nuclearsandwich nuclearsandwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should at least get us building as a temporary workaround if not the desired approach.

@chapulina chapulina merged commit e39be04 into ros2 Aug 20, 2020
Core development automation moved this from In review to Done Aug 20, 2020
@chapulina chapulina deleted the chapulina/pkg-config branch August 20, 2020 03:05
@j-rivero j-rivero removed this from Done in Core development May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ROS 2 ROS 2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants