Add support for Dome #103
Merged
Add support for Dome #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Luca Della Vedova <luca@openrobotics.org>
chapulina
suggested changes
Aug 20, 2020
Signed-off-by: Luca Della Vedova <luca@openrobotics.org>
chapulina
approved these changes
Aug 22, 2020
|
Ouch, after I merged I remembered that the That would help a colcon workspace get the correct dependencies. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just adding an additional check in the CMakeLists to look for the Dome libraries, the order of priority is:
Citadel
Dome
Blueprint (compile error if none found)
I didn't update ros_ign_point_cloud since it never supported Citadel in the first place, not sure this is intended?