Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ros_ign_gazebo exec depend on ign-gazebo #110

Merged
merged 1 commit into from
Sep 21, 2020
Merged

ros_ign_gazebo exec depend on ign-gazebo #110

merged 1 commit into from
Sep 21, 2020

Conversation

chapulina
Copy link
Contributor

It was noted on chapulina/dolly#22 that installing ros-foxy-ros-ign-gazebo doesn't install ign-gazebo. Installing the ros-ign metapackage does, because the demos package brings ign-gazebo.

Since ros_ign_gazebo calls ign gazebo on a launch file, it needs to declare the exec dependency.

CC @ruffsl

@chapulina
ros_ign_gazebo exec depend on ign-gazebo
f8199a6 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@osrf-triage osrf-triage added this to Inbox in Core development Sep 19, 2020
@chapulina chapulina mentioned this pull request Sep 19, 2020
Merged
@chapulina chapulina moved this from Inbox to In review in Core development Sep 19, 2020
@chapulina chapulina merged commit 58e0af1 into ros2 Sep 21, 2020
Core development automation moved this from In review to Done Sep 21, 2020
@chapulina chapulina deleted the chapulina/depend_gz branch September 21, 2020 19:16
@chapulina chapulina added the ROS 2 ROS 2 label Mar 10, 2021
@j-rivero j-rivero removed this from Done in Core development May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-rivero j-rivero j-rivero approved these changes

Assignees
No one assigned
Labels
ROS 2 ROS 2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chapulina @j-rivero