Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed for loading xml from ROS param(#119) #120

Merged
merged 2 commits into from
Oct 29, 2020
Merged

Changed for loading xml from ROS param(#119) #120

merged 2 commits into from
Oct 29, 2020

Conversation

chama1176
Copy link
Contributor

I have fixed #119

@chama1176 chama1176 marked this pull request as draft October 27, 2020 08:29
Changed for loading xml from ROS param(gazebosim#119)
2727430 
Signed-off-by: yakushigawa <kaede_yakushigawa@yanmar.com>
@chama1176 chama1176 marked this pull request as ready for review October 27, 2020 08:31
@chama1176 chama1176 marked this pull request as draft October 27, 2020 16:41
@chapulina chapulina added this to Inbox in Core development via automation Oct 27, 2020
@chapulina chapulina moved this from Inbox to In progress in Core development Oct 27, 2020
chapulina
chapulina suggested changes Oct 27, 2020
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR, it looks good to me once the warning is fixed.

ros_ign_gazebo/src/create.cpp Outdated Show resolved Hide resolved
Core development automation moved this from In progress to In review Oct 27, 2020
@chapulina chapulina self-assigned this Oct 27, 2020
@chama1176
fix format
e283091 
Signed-off-by: Kaede Yakushigawa <kaede6120@gmail.com>
@chama1176 chama1176 marked this pull request as ready for review October 28, 2020 13:55
chapulina
chapulina approved these changes Oct 29, 2020
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tried the exact setup on #119, but I checked that the basic behaviour still works the same way, so I don't see a problem getting this in.

Thank you for the PR!

@chapulina chapulina added ROS 2 ROS 2 🏰 citadel Ignition Citadel 🔮 dome Ignition Dome labels Oct 29, 2020
@chapulina chapulina merged commit 565bdb1 into gazebosim:ros2 Oct 29, 2020
Core development automation moved this from In review to Done Oct 29, 2020
@chapulina chapulina mentioned this pull request Oct 29, 2020
Closed
@j-rivero j-rivero removed this from Done in Core development May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

Assignees

@chapulina chapulina

Labels
🏰 citadel Ignition Citadel 🔮 dome Ignition Dome ROS 2 ROS 2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chama1176 @chapulina