[ros2] Add default value for plugin path in ign_gazebo launch script #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrej Orsula <orsula.andrej@gmail.com>
chapulina
approved these changes
Dec 8, 2020
AndrejOrsula
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #122, I have unfortunately introduced a regression in case
IGN_GAZEBO_SYSTEM_PLUGIN_PATHwas not previously set. My mistake... I forgot to test such use case prior to submitting that PR.This PR should fix it by having a default value in case it is not set. The same logic is applied also for
LD_LIBRARY_PATHbecause a similar issue could occur for non-Linux systems. I am not that familiar with Python, so I am unsure if there is a more standard way of doing this.