-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ros2] Update documentation for installation instructions and bridge examples #142
Conversation
Signed-off-by: Andrej Orsula <orsula.andrej@gmail.com>
Signed-off-by: Andrej Orsula <orsula.andrej@gmail.com>
Signed-off-by: Andrej Orsula <orsula.andrej@gmail.com>
Signed-off-by: Andrej Orsula <orsula.andrej@gmail.com>
Signed-off-by: Andrej Orsula <orsula.andrej@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it makes sense to just keep the install instructions in one place, the other libraries don't have install instructions in the particular README.md.
@chapulina do you have a different opinion ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed instructions from ros_ign_bridge/README.md
Thanks, that was already done for ROS 1 but we never updated ROS 2.
Signed-off-by: Andrej Orsula <orsula.andrej@gmail.com>
Signed-off-by: Andrej Orsula <orsula.andrej@gmail.com>
Signed-off-by: Andrej Orsula <orsula.andrej@gmail.com>
Head branch was pushed to by a user without write access
Note: Added one more commit into this PR to remove FluidPressure TODO from support matrix. Demo for it was enabled and tested in #144, but I added the commit here to avoid merge conflicts. |
馃 Bug fix
Summary
Few minor changes to installation instructions and examples for ROS 2. Tested on Ubuntu Focal, with Edifice built from source (Docker).
Installation instructions:
rosdep install
complains if Ignition libraries are included in requirementsExamples:
melodic
instead offoxy
)Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge