Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed ros ign bridge documentation #178

Merged
merged 1 commit into from
Oct 12, 2021
Merged

Conversation

ahcorde
Copy link
Collaborator

@ahcorde ahcorde commented Sep 14, 2021

Signed-off-by: ahcorde ahcorde@gmail.com

馃 Bug fix

Summary

Fixed documentation.

  • Foxy -> Galactic
  • Edifice -> Fortress

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde self-assigned this Sep 14, 2021
@osrf-triage osrf-triage added this to Inbox in Core development Sep 14, 2021
ros2 run rqt_image_view rqt_image_view /rgbd_camera/image
```

You should see the current images in `rqt_image_view` which are coming from
Gazebo (published as Ignition Msgs over Ignition Transport).

The screenshot shows all the shell windows and their expected content
(it was taken using ROS 2 Foxy and Ignition Edifice):
(it was taken using ROS 2 Galactic and Ignition Fortress):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is technically not true 馃槈

Core development automation moved this from Inbox to In review Sep 14, 2021
@ahcorde ahcorde merged commit 628e0a4 into ros2 Oct 12, 2021
@ahcorde ahcorde deleted the ahcorde/fix/ros_ign_bridge branch October 12, 2021 09:10
Core development automation moved this from In review to Done Oct 12, 2021
@j-rivero j-rivero removed this from Done in Core development May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants