-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Light Messages #187
Light Messages #187
Conversation
Signed-off-by: William Lew <WilliamMilesLew@gmail.com>
Signed-off-by: William Lew <WilliamMilesLew@gmail.com>
Signed-off-by: William Lew <WilliamMilesLew@gmail.com>
45c5fd5
to
6193d64
Compare
Signed-off-by: William Lew <WilliamMilesLew@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
I made here some suggestions WilliamLewww#1 to this PR |
suggestions to PR gazebosim#187
Signed-off-by: William Lew <WilliamMilesLew@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did a quick pass
Signed-off-by: William Lew <WilliamMilesLew@gmail.com>
Oh I forgot to mention that we should add tests for the new conversions, and document them in the README. |
Signed-off-by: William Lew <WilliamMilesLew@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bc4f65e
to
f163fdd
Compare
It seems that the |
Opened the following pull request to fix the ROS subscriber test: #189 |
…to wlew/light_message Signed-off-by: William Lew <WilliamMilesLew@gmail.com>
Signed-off-by: William Lew <WilliamMilesLew@gmail.com>
Signed-off-by: William Lew <WilliamMilesLew@gmail.com>
…into wlew/light_message
Signed-off-by: William Lew <WilliamMilesLew@gmail.com>
Signed-off-by: William Lew <WilliamMilesLew@gmail.com>
ccf734a
to
6fbf510
Compare
Signed-off-by: William Lew <WilliamMilesLew@gmail.com>
6fbf510
to
a300f18
Compare
Signed-off-by: William Lew <WilliamMilesLew@gmail.com>
Signed-off-by: William Lew <WilliamMilesLew@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: William Lew <WilliamMilesLew@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 💡
🎉 Light Messages
Depends on #189
Summary
Derived a light message for ROS2 from Ignition's light message.
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge