Added ign_version launch argument to set ignition gazebo version

[ahcorde]

Signed-off-by: ahcorde ahcorde@gmail.com

🎉 New feature

Close this PR #133

Summary

Added a new launch argument called ign_version

Test it

sudo apt-get install ignition-citadel ignition-fortress

Launch ignition Citadel (by default in Foxy)

ros2 launch ros_ign_gazebo ign_gazebo.launch.py ign_version:=3

Launch ignition Fortress

ros2 launch ros_ign_gazebo ign_gazebo.launch.py ign_version:=6

Checklist

• Signed all commits for DCO
• Added tests
• Added example and/or tutorial
• Updated documentation (as needed)
• Updated migration guide (as needed)
• codecheck passed (See contributing)
• All tests passed (See test coverage)
• While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

[chapulina]

Thanks! LGTM

The warning on the ROS farm isn't new

[doisyg]

What was the rational in renaming ign_gazebo.launch.py to ign_gazebo.launch.py.in here ? Maybe a typo ?
Anyway this is breaking implementations using this launch file

[doisyg]

hum it is actually not the name that changed but the export path:
install/ros_ign_gazebo/share/ros_ign_gazebo/launch/ign_gazebo.launch.py
to
install/ros_ign_gazebo/share/ros_ign_gazebo/ign_gazebo.launch.py