Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rssi to Dataframe.msg #249

Merged
merged 10 commits into from
May 23, 2022
Merged

Add rssi to Dataframe.msg #249

merged 10 commits into from
May 23, 2022

Conversation

caguero
Copy link
Contributor

@caguero caguero commented May 13, 2022

🎉 New feature

Summary

This patch adds a new rssi field to the ros_ign_interfaces/Dataframe.msg.

Test it

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
@caguero caguero requested a review from chapulina as a code owner May 13, 2022 16:02
@osrf-triage osrf-triage added this to Inbox in Core development May 13, 2022
<< header.data(i).value(0) << ")" << std::endl;
}
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI complains about some style issues here:

relevant output from uncrustify:

output
9: --- src/convert/ros_ign_interfaces.cpp
9: +++ src/convert/ros_ign_interfaces.cpp.uncrustify
9: @@ -212 +212 @@
9: -  auto *rssiPtr = ign_msg.mutable_header()->add_data();
9: +  auto * rssiPtr = ign_msg.mutable_header()->add_data();
9: @@ -233,7 +233,4 @@
9: -  const auto &header = ign_msg.header();
9: -  for (auto i = 0; i < header.data_size(); ++i)
9: -  {
9: -    if (header.data(i).key() == "rssi" && header.data(i).value_size() > 0)
9: -    {
9: -      try
9: -      {
9: +  const auto & header = ign_msg.header();
9: +  for (auto i = 0; i < header.data_size(); ++i) {
9: +    if (header.data(i).key() == "rssi" && header.data(i).value_size() > 0) {
9: +      try {
9: @@ -241,9 +238,6 @@
9: -      }
9: -      catch (const std::invalid_argument&)
9: -      {
9: -        std::cerr << "RSSI value is invalid ("
9: -                  << header.data(i).value(0) << ")" << std::endl;
9: -      } catch (const std::out_of_range&)
9: -      {
9: -        std::cerr << "RSSI value is out of range ("
9: -                  << header.data(i).value(0) << ")" << std::endl;
9: +      } catch (const std::invalid_argument &) {
9: +        std::cerr << "RSSI value is invalid (" <<
9: +          header.data(i).value(0) << ")" << std::endl;
9: +      } catch (const std::out_of_range &) {
9: +        std::cerr << "RSSI value is out of range (" <<
9: +          header.data(i).value(0) << ")" << std::endl;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@chapulina chapulina added the ROS 2 ROS 2 label May 13, 2022
@chapulina chapulina moved this from Inbox to In review in Core development May 13, 2022
@chapulina chapulina added the needs upstream release Blocked by a release of an upstream library label May 13, 2022
@caguero caguero added the mbzirc Sponsored by MBZIRC: https://github.com/osrf/mbzirc/ label May 19, 2022
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
@chapulina chapulina removed the needs upstream release Blocked by a release of an upstream library label May 23, 2022
@caguero caguero merged commit bdb05fe into galactic May 23, 2022
@caguero caguero deleted the caguero/rssi branch May 23, 2022 18:40
Core development automation moved this from In review to Done May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mbzirc Sponsored by MBZIRC: https://github.com/osrf/mbzirc/ ROS 2 ROS 2
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants