-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rssi to Dataframe.msg #249
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
iche033
reviewed
May 13, 2022
<< header.data(i).value(0) << ")" << std::endl; | ||
} | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI complains about some style issues here:
relevant output from uncrustify:
output
9: --- src/convert/ros_ign_interfaces.cpp
9: +++ src/convert/ros_ign_interfaces.cpp.uncrustify
9: @@ -212 +212 @@
9: - auto *rssiPtr = ign_msg.mutable_header()->add_data();
9: + auto * rssiPtr = ign_msg.mutable_header()->add_data();
9: @@ -233,7 +233,4 @@
9: - const auto &header = ign_msg.header();
9: - for (auto i = 0; i < header.data_size(); ++i)
9: - {
9: - if (header.data(i).key() == "rssi" && header.data(i).value_size() > 0)
9: - {
9: - try
9: - {
9: + const auto & header = ign_msg.header();
9: + for (auto i = 0; i < header.data_size(); ++i) {
9: + if (header.data(i).key() == "rssi" && header.data(i).value_size() > 0) {
9: + try {
9: @@ -241,9 +238,6 @@
9: - }
9: - catch (const std::invalid_argument&)
9: - {
9: - std::cerr << "RSSI value is invalid ("
9: - << header.data(i).value(0) << ")" << std::endl;
9: - } catch (const std::out_of_range&)
9: - {
9: - std::cerr << "RSSI value is out of range ("
9: - << header.data(i).value(0) << ")" << std::endl;
9: + } catch (const std::invalid_argument &) {
9: + std::cerr << "RSSI value is invalid (" <<
9: + header.data(i).value(0) << ")" << std::endl;
9: + } catch (const std::out_of_range &) {
9: + std::cerr << "RSSI value is out of range (" <<
9: + header.data(i).value(0) << ")" << std::endl;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
iche033
approved these changes
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Summary
This patch adds a new
rssi
field to theros_ign_interfaces/Dataframe.msg
.Test it
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.