Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export ROS Stopwatch library #299

Merged
merged 2 commits into from
Sep 23, 2022
Merged

Export ROS Stopwatch library #299

merged 2 commits into from
Sep 23, 2022

Conversation

andermi
Copy link
Contributor

@andermi andermi commented Sep 17, 2022

馃 Bug fix

Summary

New Stopwatch library needs to be exported and built as shared

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@andermi
export stopwatch; make shared lib
68cf540 
Signed-off-by: Michael Anderson <anderson@mbari.org>
@osrf-triage osrf-triage added this to Inbox in Core development Sep 17, 2022
@andermi andermi mentioned this pull request Sep 17, 2022
Closed
ahcorde
ahcorde requested changes Sep 19, 2022
View reviewed changes
ros_ign_gazebo/CMakeLists.txt Outdated Show resolved Hide resolved
Core development automation moved this from Inbox to In review Sep 19, 2022
@andermi
make common lib
9955401 
Signed-off-by: Michael Anderson <anderson@mbari.org>
@andermi andermi requested review from mjcarroll and ahcorde and removed request for mjcarroll September 20, 2022 16:43
@mjcarroll mjcarroll enabled auto-merge (squash) September 23, 2022 13:54
@mjcarroll mjcarroll merged commit 6ffa827 into gazebosim:galactic Sep 23, 2022
Core development automation moved this from In review to Done Sep 23, 2022
@andermi andermi mentioned this pull request Oct 3, 2022
Merged
mjcarroll added a commit that referenced this pull request Nov 1, 2022
@mjcarroll @andermi
Export ROS Stopwatch library (#299) (#322)
cc639e9 
New Stopwatch library needs to be exported and built as shared

Signed-off-by: Michael Anderson <anderson@mbari.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Co-authored-by: Michael Anderson <anderson@mbari.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjcarroll mjcarroll mjcarroll approved these changes

@ahcorde ahcorde Awaiting requested review from ahcorde

Assignees
No one assigned
Labels
None yet
Projects
Core development
Archived in project
Core development
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andermi @mjcarroll @ahcorde