Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Galactic ➡️ Humble #322

Merged
merged 2 commits into from
Nov 1, 2022
Merged

Galactic ➡️ Humble #322

merged 2 commits into from
Nov 1, 2022

Conversation

mjcarroll
Copy link
Collaborator

➡️ Forward port

Port galactic to humble

Branch comparison: humble...galactic

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

New Stopwatch library needs to be exported and built as shared

Signed-off-by: Michael Anderson <anderson@mbari.org>
@osrf-triage osrf-triage added this to Inbox in Core development Oct 31, 2022
@mjcarroll mjcarroll self-assigned this Oct 31, 2022
@mjcarroll mjcarroll moved this from Inbox to In review in Core development Oct 31, 2022
@quarkytale
Copy link
Contributor

Might want to check off DCO.
Some tests are failing in fortress+humble:

  • test_launch_test_gz_subscriber.launch.py, which I guess is fine
  • In cppcheck_rosidl_generated_c, couple of Converting unsupported gz::msgs::Any [QUATERNIOND] failed

Copy link
Contributor

@quarkytale quarkytale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm if failing tests are unrelated

Signed-off-by: Michael Carroll <michael@openrobotics.org>
@mjcarroll
Copy link
Collaborator Author

Might want to check off DCO.

Done.

Some tests are failing in fortress+humble:

Must have been flakes.

@mjcarroll mjcarroll merged commit cc639e9 into humble Nov 1, 2022
Core development automation moved this from In review to Done Nov 1, 2022
@mjcarroll mjcarroll deleted the ports/galactic_to_humble branch November 1, 2022 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants