Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Humbly bringing the Joy to gazebo. #353

Merged
merged 1 commit into from
Jan 13, 2023
Merged

Humbly bringing the Joy to gazebo. #353

merged 1 commit into from
Jan 13, 2023

Conversation

bperseghetti
Copy link
Collaborator

@bperseghetti bperseghetti commented Jan 13, 2023 •
edited
Loading

Enable using the humble gazebo bridge with Joy.

Signed-off-by: Benjamin Perseghetti bperseghetti@rudislabs.com

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

@osrf-triage osrf-triage added this to Inbox in Core development Jan 13, 2023
ahcorde
ahcorde approved these changes Jan 13, 2023
View reviewed changes
Copy link
Collaborator

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, waiting for CI

Core development automation moved this from Inbox to In review Jan 13, 2023
@mjcarroll
Copy link
Collaborator

I think this was caught up in archive.ubuntu flakiness. I'm rerunning the checks.

@bperseghetti
Humbly bringing the Joy to gazebo.
6e80a8e 
Enable using the humble gazebo bridge with Joy.

Signed-off-by: Benjamin Perseghetti <bperseghetti@rudislabs.com>
@mjcarroll mjcarroll merged commit 74dcf50 into gazebosim:humble Jan 13, 2023
Core development automation moved this from In review to Done Jan 13, 2023
@mjcarroll
Copy link
Collaborator

Thanks for iterating with me!

@bperseghetti bperseghetti deleted the pr-add-joy-humble branch January 13, 2023 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjcarroll mjcarroll mjcarroll approved these changes

@ahcorde ahcorde ahcorde approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Core development
Archived in project
Core development
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bperseghetti @mjcarroll @ahcorde