Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set on_exit_shutdown argument for gz-sim ExecuteProcess #355

Merged
merged 1 commit into from
Jan 24, 2023
Merged

Set on_exit_shutdown argument for gz-sim ExecuteProcess #355

merged 1 commit into from
Jan 24, 2023

Conversation

andermi
Copy link
Contributor

@andermi andermi commented Jan 24, 2023

Signed-off-by: Michael Anderson anderson@mbari.org

馃帀 New feature

Summary

Add launch argument to set gz-sim to be a required node: if argument on_exit_shutdown is True, set on_exit=Shutdown()

Test it

Make a launch file that includes gz_sim.launch.py as well as some other node. set gz_args to use --iterations 5000 and set on_exit_shutdown to True. When gz-sim exits, everything should quit.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@andermi
set on_exit_shutdown argument for gz-sim ExecuteProcess
4e37740 
Signed-off-by: Michael Anderson <anderson@mbari.org>
@osrf-triage osrf-triage added this to Inbox in Core development Jan 24, 2023
Core development automation moved this from Inbox to In review Jan 24, 2023
@ahcorde ahcorde merged commit 63e85a9 into gazebosim:ros2 Jan 24, 2023
Core development automation moved this from In review to Done Jan 24, 2023
@andermi andermi mentioned this pull request Jan 26, 2023
Merged
@andermi
Copy link
Contributor Author

andermi commented Sep 20, 2023

@mjcarroll It doesn't look like this PR made it into the humble branch

@mjcarroll
Copy link
Collaborator

I will backport to iron and humble, thanks.

@andermi andermi mentioned this pull request Sep 20, 2023
Closed
mjcarroll pushed a commit that referenced this pull request Sep 20, 2023
@andermi @mjcarroll
set on_exit_shutdown argument for gz-sim ExecuteProcess (#355)
8aabc20 
Signed-off-by: Michael Anderson <anderson@mbari.org>
@mjcarroll mjcarroll mentioned this pull request Sep 20, 2023
Merged
mjcarroll pushed a commit that referenced this pull request Sep 20, 2023
@andermi @mjcarroll
set on_exit_shutdown argument for gz-sim ExecuteProcess (#355)
2e5ae46 
Signed-off-by: Michael Anderson <anderson@mbari.org>
@mjcarroll mjcarroll mentioned this pull request Sep 20, 2023
Merged
@mjcarroll
Copy link
Collaborator

Humble: #451
Iron: #452

mjcarroll added a commit that referenced this pull request Sep 21, 2023
@mjcarroll @andermi
set on_exit_shutdown argument for gz-sim ExecuteProcess (#355) (#451)
0585429 
Signed-off-by: Michael Anderson <anderson@mbari.org>
Co-authored-by: andermi <anderson@mbari.org>
mjcarroll added a commit that referenced this pull request Sep 21, 2023
@mjcarroll @andermi
set on_exit_shutdown argument for gz-sim ExecuteProcess (#355) (#452)
bc4f777 
Signed-off-by: Michael Anderson <anderson@mbari.org>
Co-authored-by: andermi <anderson@mbari.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde ahcorde approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Core development
Archived in project
Core development
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andermi @mjcarroll @ahcorde