Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix warning message #371

Merged
merged 1 commit into from
Mar 11, 2023
Merged

fix warning message #371

merged 1 commit into from
Mar 11, 2023

Conversation

ejalaa12
Copy link
Contributor

@ejalaa12 ejalaa12 commented Mar 10, 2023

馃 Bug fix

Summary

The warning message had the ros_type and gz_type swapped out, which woud throw warnings that looked like this:

Failed to create a bridge for topic [ros_topic_name] with ROS2 type [gz_topic_name] to topic [sensor_msgs.msg.Imu] with Gazebo Transport type [gz.msgs.IMU]

The line in the code were swapped out. This PR just fixes that

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Signed-off-by: Alaa El Jawad <ejalaa12@gmail.com>
@osrf-triage osrf-triage added this to Inbox in Core development Mar 10, 2023
Core development automation moved this from Inbox to In review Mar 10, 2023
@azeey
Copy link
Contributor

azeey commented Mar 11, 2023

CI failure appears unrelated. Merging!

@azeey azeey merged commit 18be705 into gazebosim:ros2 Mar 11, 2023
Core development automation moved this from In review to Done Mar 11, 2023
@ejalaa12 ejalaa12 deleted the fix-warning-msg branch March 13, 2023 11:34
azeey pushed a commit to azeey/ros_gz that referenced this pull request Apr 28, 2023
Signed-off-by: Alaa El Jawad <ejalaa12@gmail.com>
azeey pushed a commit that referenced this pull request May 1, 2023
Signed-off-by: Alaa El Jawad <ejalaa12@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants