Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Altimeter msg bridging #413

Merged
merged 2 commits into from
Jun 14, 2023
Merged

Added Altimeter msg bridging #413

merged 2 commits into from
Jun 14, 2023

Conversation

adityapande-1995
Copy link
Contributor

@adityapande-1995 adityapande-1995 commented Jun 13, 2023 •
edited
Loading

🎉 New feature

Summary

This PR adds a new message to ros_gz_interfaces for altimeter readings and bridges it to the equivalent message in gz-msgs.

Test it

WIP

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@adityapande-1995
Added Altimeter msg bridging
9634c73 
Signed-off-by: Aditya Pande <adityapande@google.com>
@osrf-triage osrf-triage added this to Inbox in Core development Jun 13, 2023
Core development automation moved this from Inbox to In review Jun 13, 2023
@adityapande-1995
Added msg
5f249b3 
Signed-off-by: Aditya Pande <adityapande@google.com>
@adityapande-1995 adityapande-1995 mentioned this pull request Jun 13, 2023
Open
@ahcorde ahcorde merged commit 606ee57 into ros2 Jun 14, 2023
5 checks passed
Core development automation moved this from In review to Done Jun 14, 2023
@ahcorde ahcorde deleted the aditya/altimeter_msg branch June 14, 2023 07:15
ahcorde pushed a commit that referenced this pull request Jun 14, 2023
@adityapande-1995 @ahcorde
Added Altimeter msg bridging (#413)
55918aa 
Signed-off-by: Aditya Pande <adityapande@google.com>
@ahcorde ahcorde mentioned this pull request Jun 14, 2023
Merged
9 tasks
ahcorde added a commit that referenced this pull request Jun 21, 2023
@ahcorde @adityapande-1995
[backport Iron] Added Altimeter msg bridging (#413) (#414)
a3071cf 
Signed-off-by: Aditya Pande <adityapande@google.com>
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Co-authored-by: Aditya Pande <aditya050995@gmail.com>
ahcorde added a commit that referenced this pull request Jun 21, 2023
@ahcorde @adityapande-1995
[backport Iron] Added Altimeter msg bridging (#413) (#414)
68288d4 
Signed-off-by: Aditya Pande <adityapande@google.com>
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Co-authored-by: Aditya Pande <aditya050995@gmail.com>
@ahcorde ahcorde mentioned this pull request Jun 21, 2023
Merged
9 tasks
mjcarroll pushed a commit that referenced this pull request Jun 21, 2023
@ahcorde @adityapande-1995
[backport Iron] Added Altimeter msg bridging (#413) (#414) (#426)
bdfe874 
Signed-off-by: Aditya Pande <adityapande@google.com>
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Co-authored-by: Aditya Pande <aditya050995@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjcarroll mjcarroll mjcarroll approved these changes

@ahcorde ahcorde ahcorde approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Core development
Archived in project
Core development
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@adityapande-1995 @mjcarroll @ahcorde