Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added more topic to the bridge #422

Merged
merged 1 commit into from Jun 16, 2023
Merged

Added more topic to the bridge #422

merged 1 commit into from Jun 16, 2023

Conversation

ahcorde
Copy link
Collaborator

@ahcorde ahcorde commented Jun 16, 2023

🎉 New feature

Summary

Added more topic to the rgbd_camera tutorial. This will allow us to use camera and DepthCloud rviz default plugins

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@ahcorde
Added more topic to the bridge
11d7eec 
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
@ahcorde ahcorde self-assigned this Jun 16, 2023
@ahcorde ahcorde requested a review from mjcarroll June 16, 2023 14:10
@osrf-triage osrf-triage added this to Inbox in Core development Jun 16, 2023
Core development automation moved this from Inbox to In review Jun 16, 2023
@ahcorde ahcorde merged commit 342b03b into ros2 Jun 16, 2023
6 checks passed
Core development automation moved this from In review to Done Jun 16, 2023
@ahcorde ahcorde deleted the ahcorde/ros2/improve_rgbd_tutorial branch June 16, 2023 22:12
ahcorde added a commit that referenced this pull request Jun 19, 2023
@ahcorde
Added more topic to the bridge (#422)
c746788 
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
ahcorde added a commit that referenced this pull request Jun 19, 2023
@ahcorde
Added more topic to the bridge (#422)
1b330a5 
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
@ahcorde ahcorde mentioned this pull request Jun 19, 2023
Merged
9 tasks
ahcorde added a commit that referenced this pull request Jun 20, 2023
@ahcorde
Added more topic to the bridge (#422) (#423)
942e5ae 
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
ahcorde added a commit that referenced this pull request Jun 20, 2023
@ahcorde
Merge pull request #424 from gazebosim/ahcorde/humble/bp/422
f923bcf 
[backport Humble] Added more topic to the bridge (#422)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iche033 iche033 iche033 approved these changes

@mjcarroll mjcarroll Awaiting requested review from mjcarroll

Assignees

@ahcorde ahcorde

Labels
None yet
Projects
Core development
Archived in project
Core development
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ahcorde @iche033