Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed install instructions #435

Merged
merged 1 commit into from
Jul 17, 2023
Merged

Fixed install instructions #435

merged 1 commit into from
Jul 17, 2023

Conversation

ahcorde
Copy link
Collaborator

@ahcorde ahcorde commented Jul 17, 2023

🦟 Bug fix

Fixes #434

Summary

Fixed install instructions

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@ahcorde
Fixed install instructions
4587553 
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
@ahcorde ahcorde requested a review from mjcarroll July 17, 2023 10:24
@ahcorde ahcorde self-assigned this Jul 17, 2023
@osrf-triage osrf-triage added this to Inbox in Core development Jul 17, 2023
@ahcorde ahcorde mentioned this pull request Jul 17, 2023
Open
Core development automation moved this from Inbox to In review Jul 17, 2023
@ahcorde ahcorde merged commit 07f8adc into ros2 Jul 17, 2023
6 checks passed
Core development automation moved this from In review to Done Jul 17, 2023
@ahcorde ahcorde deleted the ahcorde/rolling/readme/update branch July 17, 2023 15:30
ahcorde added a commit that referenced this pull request Jul 17, 2023
@ahcorde
Fixed install instructions (#435)
adb896e 
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
ahcorde added a commit that referenced this pull request Jul 17, 2023
@ahcorde
Fixed install instructions (#435)
0da0f3d 
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
This was referenced Jul 17, 2023
Merged
Merged
ahcorde added a commit that referenced this pull request Jul 17, 2023
@ahcorde
Fixed install instructions (#435) (#436)
d7b7235 
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
ahcorde added a commit that referenced this pull request Jul 17, 2023
@ahcorde
Fixed install instructions (#435) (#437)
eb63bce 
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjcarroll mjcarroll mjcarroll approved these changes

Assignees

@ahcorde ahcorde

Labels
None yet
Projects
Core development
Archived in project
Core development
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

README installation instructions
2 participants
@ahcorde @mjcarroll