Correctly export ros_gz_bridge for downstream targets #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
ahcorde
requested changes
Feb 22, 2024
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
ahcorde
approved these changes
Feb 22, 2024
|
are you going to backport this? |
mjcarroll
added a commit
that referenced
this pull request
Feb 23, 2024
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
mjcarroll
added a commit
that referenced
this pull request
Feb 23, 2024
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
ahcorde
pushed a commit
that referenced
this pull request
Feb 23, 2024
mjcarroll
added a commit
that referenced
this pull request
Feb 23, 2024
caguero
pushed a commit
that referenced
this pull request
Mar 29, 2024
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai> Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally adds a
test_ros_gz_bridgetarget to verify that this behavior is working.We could also put our integration tests in here in the long run, but I will leave that to a follow up.
Replaces #496