Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport Humble] Added conversion for Detection3D and Detection3DArray (#523) #526

Merged
merged 1 commit into from Apr 2, 2024

Conversation

ahcorde
Copy link
Collaborator

@ahcorde ahcorde commented Apr 1, 2024

馃 Bug fix

Summary

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: wittenator <9154515+wittenator@users.noreply.github.com>
@ahcorde ahcorde requested review from azeey and mjcarroll April 1, 2024 16:32
@ahcorde ahcorde self-assigned this Apr 1, 2024
@iche033
Copy link
Contributor

iche033 commented Apr 1, 2024

are the build failures expected?

@ahcorde
Copy link
Collaborator Author

ahcorde commented Apr 1, 2024

@iche033 This is the humble branch not sure why this is compiling against rolling too

@iche033
Copy link
Contributor

iche033 commented Apr 1, 2024

ok sounds like a separate CI setup issue.

@ahcorde ahcorde merged commit 409a941 into humble Apr 2, 2024
9 of 16 checks passed
@ahcorde ahcorde deleted the ahcorde/humble/523 branch April 2, 2024 07:48
@ahcorde
Copy link
Collaborator Author

ahcorde commented Apr 2, 2024

ok sounds like a separate CI setup issue.

@iche033 #527

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants