Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Port ign_ros_gazebo_demos to ROS2 #58

Merged
merged 26 commits into from
Dec 11, 2019
Merged

Conversation

j-rivero
Copy link
Contributor

First effort to port ros_gazebo_demos to ROS2

All launch XML files have been converted to python. All components of the old XML launch configuration are present in the current python files.

There still major problems:

  • The bridge fails to me on every launch file I ported, not sure why probably something stupid, with these kind of errors:
[parameter_bridge-2] Failed to create a bridge for topic [/rgbd_camera/image] with ROS2 type [sensor_msgs/Image] and Ignition Transport type [ignition.msgs.Image]
  • Some files can not be ported yet until other packages in the repo are ported (comment done in launch file).
  • ign gazebo parameters -r -v present in some files were not ported. I was unable to pass these paremeters correctly.
  • Seems like all rviz configurations needs porting and some features are missing. None of them worked out of the box.
  • We need to investigate the problems with ignition-gazebo3 cmake (complaining about DART cmake bad used). Code is commented out by now.

j-rivero and others added 21 commits December 10, 2019 00:30
Signed-off-by: Louise Poubel <louise@openrobotics.org>
…lude-hidden-topics]

                  Call `ros2 topic <command> -h` for more detailed usage. ...

Various topic related sub-commands

optional arguments:
  -h, --help            show this help message and exit
  --include-hidden-topics
                        Consider hidden topics as well

Commands:
  bw     Display bandwidth used by topic
  delay  Display delay of topic from timestamp in header
  echo   Output messages from a topic
  hz     Print the average publishing rate to screen
  info   Print information about a topic
  list   Output a list of available topics
  pub    Publish a message to a topic

  Call `ros2 topic <command> -h` for more detailed usage.

Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina
Copy link
Contributor

I added a few changes in 6b5063e, addressing demos down to differential drive.

The bridge fails to me on every launch file I ported

I think the main problem is the missing msg namespace, i.e. geometry_msgs/Twist in ROS 1 becomes geometry_msgs/msg/Twist in ROS 2. Besides that, it looks like we still need to port other messages, like FluidPressure.

Seems like all rviz configurations needs porting and some features are missing. None of them worked out of the box.

I think we can just regenerate them by manually adding the displays and saving the new config. I'm not sure if the configs are meant to be portable from ROS 1 to ROS 2, so I think it's ok to do this for all demos.

Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina mentioned this pull request Dec 11, 2019
John and others added 4 commits December 11, 2019 13:10
Port ros ign image to ros2
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @j-rivero and @JShep1 for the collective effort! All packages and demos that could be migrated have been migrated!

Some are blocked by ros_ign_point_cloud (also a problem on ROS 1), and the air_pressure demo is blocked because we haven't migrated the FluidPressure message yet.

@chapulina chapulina merged commit ee88cdd into dashing Dec 11, 2019
@chapulina chapulina deleted the port_dashing_demos branch December 11, 2019 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants