Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ros2] Fixed CI - Added Foxy #89

Merged
merged 3 commits into from
Jun 29, 2020
Merged

[ros2] Fixed CI - Added Foxy #89

merged 3 commits into from
Jun 29, 2020

Conversation

ahcorde
Copy link
Collaborator

@ahcorde ahcorde commented Jun 26, 2020

Fixed CI

  • Added Foxy
  • Removed Eloquent and Dashing

@ahcorde
Fixed travis
485f4d0 
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde
make linters happy
104dfd0 
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde added the enhancement New feature or request label Jun 26, 2020
@ahcorde ahcorde requested a review from chapulina June 26, 2020 11:08
@ahcorde ahcorde self-assigned this Jun 26, 2020
@osrf-triage osrf-triage added this to Inbox in Core development Jun 26, 2020
@ahcorde ahcorde mentioned this pull request Jun 26, 2020
Merged
@ahcorde ahcorde changed the title Fixed CI - Added Foxy [ros2] Fixed CI - Added Foxy Jun 26, 2020
@chapulina chapulina moved this from Inbox to In review in Core development Jun 29, 2020
@chapulina
Update README
1139fb6 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
chapulina
chapulina approved these changes Jun 29, 2020
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM! I updated the README with info about this branch on 1139fb6

@chapulina chapulina merged commit 8cd6ea7 into ros2 Jun 29, 2020
Core development automation moved this from In review to Done Jun 29, 2020
@chapulina chapulina deleted the ahcorde/fix/ci_ros2 branch June 29, 2020 19:15
@j-rivero j-rivero removed this from Done in Core development May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

Assignees

@ahcorde ahcorde

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ahcorde @chapulina