-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integer support #91
Integer support #91
Conversation
Signed-off-by: mohamedsayed18 <mohamed95.a.s@gmail.com>
Signed-off-by: mohamedsayed18 <mohamed95.a.s@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me! I tried with:
-
Terminal 1:
ros2 run ros_ign_bridge parameter_bridge /chatter@std_msgs/msg/Int32@ignition.msgs.Int32
-
Terminal 2:
ros2 topic echo /chatter
-
Terminal 3:
ign topic pub -t /chatter -m ignition.msgs.Int32 -p 'data:1'
Just one other request, could you list the new message in the table in the README?
Signed-off-by: mohamedsayed18 <mohamed95.a.s@gmail.com>
Signed-off-by: mohamedsayed18 <mohamed95.a.s@gmail.com>
I added Int32 to the readme and fixed the alphabetic order |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM!
Adding support for Int32 data type