Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install only what's necessary, rename builtin_interfaces #95

Merged
merged 2 commits into from
Jul 23, 2020
Merged

Install only what's necessary, rename builtin_interfaces #95

merged 2 commits into from
Jul 23, 2020

Conversation

chapulina
Copy link
Contributor

@chapulina chapulina commented Jul 22, 2020 •
edited
Loading

Moved some headers from include to src because they don't need to be installed.

I also removed builtin_interfaces from the names of a few files, because I don't think they only refer to this package anymore.

⚠️ Due to all the moved files, please don't squash-merge.

@osrf-triage osrf-triage added this to Inbox in Core development Jul 22, 2020
@chapulina chapulina added ROS 2 ROS 2 🏰 citadel Ignition Citadel 📜 blueprint Ignition Blueprint labels Jul 22, 2020
This was referenced Jul 22, 2020
Merged
Closed
@chapulina chapulina moved this from Inbox to In review in Core development Jul 22, 2020
j-rivero
j-rivero approved these changes Jul 22, 2020
View reviewed changes
Copy link
Contributor

@j-rivero j-rivero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nitpick about code style (not sure if its correct).

ros_ign_bridge/src/convert.cpp Outdated Show resolved Hide resolved
@chapulina
Move headers to src, rename builtin_interfaces (#95)
5e80c48 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina
Install only what's necessary, rename builtin_interfaces (#95)
1c07b38 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina
Copy link
Contributor Author

Re-triggering Travis (for some reason I don't have permissions to do it through their UI)

@chapulina chapulina closed this Jul 23, 2020
Core development automation moved this from In review to Done Jul 23, 2020
@chapulina chapulina reopened this Jul 23, 2020
Core development automation moved this from Done to Inbox Jul 23, 2020
@chapulina chapulina merged commit bf7bccb into dashing Jul 23, 2020
Core development automation moved this from Inbox to Done Jul 23, 2020
@chapulina chapulina deleted the chapulina/dashing/builtin branch July 23, 2020 01:04
@chapulina
Copy link
Contributor Author

Due to all the moved files, please don't squash-merge.

... and I squashed 🤦

@chapulina
Copy link
Contributor Author

Phew, ok, we're good, GitHub is smart and the moved files kept their history: https://github.com/ignitionrobotics/ros_ign/blame/dashing/ros_ign_bridge/src/factories.hpp

@chapulina chapulina mentioned this pull request Jul 23, 2020
Merged
@j-rivero j-rivero removed this from Done in Core development May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-rivero j-rivero j-rivero approved these changes

Assignees
No one assigned
Labels
📜 blueprint Ignition Blueprint 🏰 citadel Ignition Citadel ROS 2 ROS 2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chapulina @j-rivero