allow converting from/to TwistWithCovarianceStamped #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alaa El Jawad <ejalaa12@gmail.com>
adityapande-1995
requested changes
Mar 20, 2023
ros_gz_bridge/README.md
Outdated
Comment on lines
30
to
47
| | geometry_msgs/msg/TransformStamped | ignition::msgs::Pose | | ||
| | geometry_msgs/msg/Twist | ignition::msgs::Twist | | ||
| | geometry_msgs/msg/TwistWithCovariance | ignition::msgs::TwistWithCovariance | | ||
| | geometry_msgs/msg/TwistWithCovarianceStamped | ignition::msgs::TwistWithCovariance | | ||
| | nav_msgs/msg/Odometry | ignition::msgs::Odometry | | ||
| | nav_msgs/msg/Odometry | ignition::msgs::OdometryWithCovariance | | ||
| | rcl_interfaces/msg/ParameterValue | ignition::msgs::Any | | ||
| | ros_gz_interfaces/msg/Contact | ignition::msgs::Contact | | ||
| | ros_gz_interfaces/msg/Contacts | ignition::msgs::Contacts | | ||
| | ros_gz_interfaces/msg/Dataframe | ignition::msgs::Dataframe | | ||
| | ros_gz_interfaces/msg/Entity | ignition::msgs::Entity | | ||
| | ros_gz_interfaces/msg/Float32Array | ignition::msgs::Float_V | | ||
| | ros_gz_interfaces/msg/GuiCamera | ignition::msgs::GUICamera | | ||
| | ros_gz_interfaces/msg/JointWrench | ignition::msgs::JointWrench | | ||
| | ros_gz_interfaces/msg/Light | ignition::msgs::Light | | ||
| | ros_gz_interfaces/msg/StringVec | ignition::msgs::StringMsg_V | | ||
| | ros_gz_interfaces/msg/TrackVisual | ignition::msgs::TrackVisual | | ||
| | ros_gz_interfaces/msg/VideoRecord | ignition::msgs::VideoRecord | |
There was a problem hiding this comment.
Could you fix the vertical table alignment and keep the namespace as "gz::" ?
There was a problem hiding this comment.
Nice catch, I was probably working on a wrong branch with ignition instead of gz. I'll a an amend commit to clean this up
Signed-off-by: Alaa El Jawad <ejalaa12@gmail.com>
|
sorry for the delay in answer @adityapande-1995 |
9 tasks
|
@adityapande-1995 Did you have time to review my changes ? |
|
@ahcorde just fixed the conflicts |
ahcorde
approved these changes
May 11, 2023
adityapande-1995
approved these changes
May 22, 2023
Signed-off-by: Alejandro Hern谩ndez Cordero <ahcorde@gmail.com>
|
Thanks for the review and the merge ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃帀 New feature
Allows converting from/to TwistWithCovarianceStamped
Summary
ros_gz_bridgeallows convertinggz.msgs.TwistWithCovariance<->geometry_msgs.msg.TwistWithCovariance.However the
gz.msgs.TwistWithCovariancealso contains a header and stamp. So it could be converted to ageometry_msgs.msg.TwistWithCovariance**Stamped**.This PR implements that conversion. It is now possible to convert either to/from:
geometry_msgs.msg.TwistWithCovariancegeometry_msgs.msg.TwistWithCovarianceStamped.Note: I also have a backport of that commit to the humble branch, should I open it after this PR is done ?
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.